Add missing SpecifiedTypes for count and strlen identical expressions #1021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled over this while debugging something in the webmozart-assert extension.
This adds missing
SpecifiedTypes
forcount
,sizeof
andstrlen
expressions used viaIdentical
.E.g.
count($list) === 1
would previously result in the sureTypeNonEmptyArrayType
for$list
. Now additionally it has aConstantIntegerType
with value 1 forcount($list)
.This is a tiny thing, but improved something in
bug-2648.php
and it should close phpstan/phpstan-webmozart-assert#68 if I'm not mistaken.The first new test case in
TypeSpecifierTestCase
shows that it worked already forGreaterOrEqual
before.